Skip to content

Conversation

SundareshSankaran
Copy link
Contributor

@SundareshSankaran SundareshSankaran commented Aug 27, 2025

Please include answers to these questions as part of your pull request

In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Make sure there are no blanks inside the brackets, otherwise MarkDown doesn't render properly. Using the Preview tab while editing this form, you can see the formatted/rendered version of the message.

  • Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).
    • Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
    • No
  • Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.
    • My contribution does NOT include PII data
    • My contribution includes PII data
  • Q3: Confirm your contribution does not include any encryption or other export-controlled technology.
    • My contribution does NOT contain encryption or other export-controlled technology
    • My contribution includes encryption or other export-controlled technology

@SundareshSankaran
Copy link
Contributor Author

Continuing my new practice of starting a Draft PR (to signal my plans in advance).

Signed-off-by: SundareshSankaran <[email protected]>
Signed-off-by: SundareshSankaran <[email protected]>
Signed-off-by: SundareshSankaran <[email protected]>
@Criptic Criptic added the new custom step This pull request represents a new custom step label Aug 29, 2025
@SundareshSankaran
Copy link
Contributor Author

ContributorAgreement.txt

@SundareshSankaran
Copy link
Contributor Author

SundareshSankaran commented Aug 29, 2025

Hi @snlwih and @Criptic ,

PR for review. As part of exercise to revamp existing Python Virtual Environments, this is the second on the list. I expect a final contribution (combining Obtain requirements and Freeze requirements) to round off the list.

Note that over the course of testing this, I found a condition in Create a Virtual Environment that breaks this step. Therefore, this PR also contains an update to the Create a Virtual Environment step. Please let me know in case of any questions.

@SundareshSankaran SundareshSankaran marked this pull request as ready for review August 29, 2025 20:25
@snlwih
Copy link
Collaborator

snlwih commented Sep 1, 2025

@SundareshSankaran , as you also included an update to the Python - Create Virtual Environments step in this same PR, you should also include an updated README.md for that step with a change log that also lists the new x.x.1 version and an explanation. The About tab of that step should reference that new updated version number if it didn't do so already.

@snlwih snlwih added the update custom step This pull request updates an existing custom step label Sep 1, 2025
@snlwih snlwih changed the title New Custom Step : Python - Switch Environments (Also consider upgrade / replacements of two earlier custom steps) New: Python - Switch Environments / Update: Python - Create Virtual Environments / Update: Python Virtual environment Sep 1, 2025
@SundareshSankaran
Copy link
Contributor Author

SundareshSankaran commented Sep 1, 2025

Thanks, @snlwih , I pushed the same just now.

Screenshot 2025-09-01 at 8 43 48 am

SundareshSankaran and others added 3 commits September 1, 2025 11:18
Updated notes to use GitHub Alert notation, so it shows a colorfoul icon.

Signed-off-by: snlwih <[email protected]>
Repeated note that points to replacement steps in sections for each individual step that is impacted.

Signed-off-by: snlwih <[email protected]>
@snlwih
Copy link
Collaborator

snlwih commented Sep 2, 2025

SAS Internal Due Diligence Review - COMPLETED on 02SEP2025

@snlwih snlwih merged commit ef582b8 into sassoftware:main Sep 2, 2025
1 check passed
@SundareshSankaran SundareshSankaran deleted the 49-update-python---revert-to-original-environment branch September 2, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new custom step This pull request represents a new custom step update custom step This pull request updates an existing custom step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants